-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: add rule type check for flowbits v8 #1532
tests: add rule type check for flowbits v8 #1532
Conversation
Task #6309
Task #6309
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this is missing @jufajardini 's review update from the last PR. ref: #1529 (comment)
Please fix that. From the first look, it's looking good otherwise :)
Sorry, I just saw the comment. I was wondering if we need a rule for |
I think we could keep it. My reasoning for this is that with this Adding the check to the |
Okay, I'm not sure how to alter the yaml file such that the |
That's ok, we're figuring this one out as we progress :) From the eve log from the previous PR (#1529 (comment)), I think that we can: flag[4]: "noalert" I've tried a local test, and this seems to work. |
New PR: #1542 |
Task #6309
Redmine ticket: https://redmine.openinfosecfoundation.org/issues/6309
Previous PR: #1529
Suricata PR: OISF/suricata#10026
Output from console:
Output from stdout file: